Use Forwardable within Message to avoid method boilerplate #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Tests are failing. I think you might want to look into https://ruby-doc.org/stdlib-2.6.2/libdoc/forwardable/rdoc/Forwardable.html |
GabrielMalakias
changed the title
|
Done |
|
Awesome work! Thanks! |
januszm
reviewed
Nov 14, 2021
| :attributes, | ||
| :md5_of_message_attributes, | ||
| :message_attributes) | ||
|
|
There was a problem hiding this comment.
A minor thing but skipping the parentheses in this case would match the macro-style methods better and also sorting the lines ascending would make it easier to read, e.g.:
def_delegators :attributes,
:body,
:data,
:md5_of_body,
:md5_of_message_attributes,
:message_attributes,
:message_id,
:receipt_handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for maintaining this gem! I really appreciate your efforts.
While diving into the code I just noticed that a bunch of methods were defined just as a proxy to the data structure.
As I have seen here: https://github.com/ruby-shoryuken/shoryuken/blob/master/lib/shoryuken.rb#L48 I decided to use the SingleForwardable to delegate to the structure directly.
It's a small thing for now but might the beginning of some contributions